Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Scabrero/users fix empty displayname #1111

Merged
merged 5 commits into from Mar 12, 2014
Merged

Scabrero/users fix empty displayname #1111

merged 5 commits into from Mar 12, 2014

Conversation

scabrero
Copy link
Contributor

No description provided.

jacalvo
jacalvo reviewed Mar 10, 2014
View reviewed changes
main/core/src/EBox/CGI/ClientRawBase.pm
@@ -196,12 +196,14 @@ sub run
"a bug, relevant information can ".
"be found in the logs.");
$self->_print_error($error);
EBox::trace();
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is this intended? or just a forgotten debug?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

forgotten debug.

I have a better approach to fix this issue + some extra fixes to the displayname field handling. I'm just extending anste tests now to validate the changes (I already validated them manually)

@carlosperello
Copy link
Contributor

I updated the users/standalone-with-samba suite to test the displayname field edition and user selection that was failing...

Standalone basic users operations Test Suite with samba enabled
    InstallNonProfilePackages: OK
    EnableUsersZentyalTest: OK
    LetSambaProvision: OK
    AddUserWithNonASCIIChars: OK
    EditUserWithNonASCIIChars: OK
    AddGroup: OK
    AddUserToGroup: OK
    AddUser: OK
    CheckUser: OK
    EditUser: OK
    EditUserDisplayName: OK
    CheckUserDisplayName: OK
    EditUserDisplayNameSetEmpty: OK
    CheckUserDisplayName: OK
    AddGroup: OK
    AddUserToGroup: OK
    CheckGroup: OK
    DelUser: OK
    CheckDeletedUser: OK
    AddOU: OK
    AddUserToOU: OK
    CheckUSer: OK
    CheckSSHLoginWithoutPAM: OK
    EnablePAM: OK
    CheckSSHLoginWithPAM: OK
    AddDistributionGroup: OK
    EditDistributionGroup: OK
    ChangeDistributionGroupType: OK
    AddSecurityGroup: OK
    EditSecurityGroup: OK
    ChangeSecurityGroupType: OK
    CheckSambaPostGroupAddRemoval: OK
    CheckSambaPostGroupAddMembershipRemovalAndAdding: OK
    check-zentyal-log: OK
    check-syslog-apparmor: OK

jacalvo added a commit that referenced this pull request Mar 12, 2014
@jacalvo
Merge pull request #1111 from Zentyal/scabrero/users-fix-empty-displa…
358eae9 
…yname

Scabrero/users fix empty displayname
@jacalvo jacalvo merged commit 358eae9 into master Mar 12, 2014
@jacalvo jacalvo deleted the scabrero/users-fix-empty-displayname branch March 12, 2014 17:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@scabrero @carlosperello @jacalvo